search

OCA / server-auth

https://odoo-community.org/psc-teams/tools-30
GNU Affero General Public License v3.0
146 stars 399 forks source link

[16.0] auth_saml: Error in tests #664

Closed pedrobaeza closed 1 month ago

pedrobaeza commented 1 month ago

There's an error in current tests that makes the branch red

2024-06-10T07:10:36.6330840Z 2024-06-10 07:10:36,630 860 ERROR odoo odoo.addons.auth_saml.tests.test_pysaml: FAIL: TestPySaml.test_redirect_after_login
2024-06-10T07:10:36.6332132Z Traceback (most recent call last):
2024-06-10T07:10:36.6333323Z   File "/__w/server-auth/server-auth/auth_saml/tests/test_pysaml.py", line 332, in test_redirect_after_login
2024-06-10T07:10:36.6334388Z     self.assertTrue(response.ok)
2024-06-10T07:10:36.6334958Z AssertionError: False is not true
2024-06-10T07:10:36.6335248Z

@vincent-hatakeyama @leemannd @szekawong can you please check?

pedrobaeza commented 1 month ago

Any news? If not, I will need to disable the tests for having green CI.

vincent-hatakeyama commented 1 month ago

The test fails since f0abd14f8118a815fda44a99274252e1fe93af1b, before that they did not.

The test did not fail before that change and the module was not changed.

That commit changed some dot files so I guess the way tests are run have changed.

The test also fails in 17.0 in the migration PR #634

pedrobaeza commented 1 month ago

That commit didn't change anything in the way the tests are doing. It's probably a coincidence with a change upstream.

vincent-hatakeyama commented 1 month ago

I’ll try to see why this is the only tests that is broken and fix it.

vincent-hatakeyama commented 1 month ago

Linked PR fixes the issue.

The module might have been broken or maybe just the tests if that savepoint error only happened there.

pedrobaeza commented 1 month ago

Thanks for the promptness!