OCA / server-backend

GNU Affero General Public License v3.0
96 stars 263 forks source link

[12.0][IMP] base_global_discount: add fixed discount selection #264

Closed primes2h closed 1 month ago

primes2h commented 8 months ago

It adds fixed discount as global discount type.

See https://github.com/OCA/server-backend/pull/267 for v. 14.0.

ygol commented 8 months ago

hello, Is it within this scope to add global discount amount either based on tax included/excluded base? Example with fix discount based on included TAX: 2046.45 before tax -900 discount 112.55 TAX 2159 Tax included -900 1259 after discount Thank you

primes2h commented 8 months ago

hello, Is it within this scope to add global discount amount either based on tax included/excluded base? Example with fix discount based on included TAX: 2046.45 before tax -900 discount 112.55 TAX 2159 Tax included -900 1259 after discount Thank you

Hello, fixed discounts don't work with subtotal when you have more than one invoice line. [*] When invoice lines are >= 2 you don't know how to proportionally distribute discount on the lines.

[*] with one line, fixed discount is covered by https://github.com/OCA/account-invoicing/tree/12.0/account_invoice_fixed_discount

primes2h commented 8 months ago

[*] with one line, fixed discount is covered by https://github.com/OCA/account-invoicing/tree/12.0/account_invoice_fixed_discount

I mean, with one or more lines.

ygol commented 8 months ago

[*] with one line, fixed discount is covered by https://github.com/OCA/account-invoicing/tree/12.0/account_invoice_fixed_discount

I mean, with one or more lines.

Thank you @primes2h

primes2h commented 7 months ago

[*] with one line, fixed discount is covered by https://github.com/OCA/account-invoicing/tree/12.0/account_invoice_fixed_discount

I mean, with one or more lines.

Thank you @primes2h

You're welcome! Feel free to do a review if you want. ;-)

github-actions[bot] commented 2 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.