search

OCA / server-backend

GNU Affero General Public License v3.0
104 stars 274 forks source link

[MIG] base_dav: Migration to 17.0 #269

Open jaydeep32 opened 9 months ago

jaydeep32 commented 9 months ago

To install and use this module, use the right version of radicale==2.1.12 python package. This PR for this #254

jaydeep32 commented 8 months ago

It is missing because this module is on v11, and in between form 12-16 versions this module was not migrated.

dreispt commented 8 months ago

@jaydeep32 the migration should get the commits from the previous available version, 11.0 in that case, and then add changes to it. The commit history procedure is explained in the migration Issue of the repo. Just replace 16.0 with 11.0.

jaydeep32 commented 8 months ago

Hi, @dreispt. Copying the commit from 11.0 and adding it to this branch is very complex for me, so is it okay if I make a new PR with an 11.0 history for this module, and then we can close this one?

dreispt commented 8 months ago

@jaydeep32 Did you try the migration recipe, replacing 15.0 with 11.0? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#technical-method-to-migrate-a-module-from-150-to-160-branch

jaydeep32 commented 8 months ago

Yes, I have, but like in my current branch if I make this, it makes many conflicts with new module changes, making it harder to resolve. However, it would work well if I created a new branch and then did this. So this is why I asked if I could make a new branch and PR.

dreispt commented 8 months ago

@jaydeep32 Yes, you should use the recipe to create a new clean branch, and after that add your migration changes. Let me know if you need help.

jaydeep32 commented 8 months ago

Hello @dreispt Now is it ok? I have added those commits from 11.0 to this one.

dreispt commented 8 months ago

@jaydeep32 Great work, you made it! Now I can see your migration changes. I made a couple of questions, thanks.

dreispt commented 8 months ago

@amh-mw You're right. @jaydeep32 I ran the migration process myself and applied your changes, here https://github.com/OCA/server-backend/pull/276 This has the correct history.

I suggest you fetch my branch, git reset this branch to it, and continue from there.

flotho commented 4 months ago

thanks for this PR. I thinks some ACL are missing for http://oca-server-backend-17-0-pr269-360893ee9167.runboat.odoo-community.org/web?debug=1#id=1&cids=1&menu_id=65&action=77&model=dav.collection&view_type=form image

mostly impossible to configure this in the UI

eLBati commented 4 months ago

Should we move to https://github.com/OCA/server-backend/pull/276 ?

josselex commented 1 month ago

Is there any progress on it? Maybe even upgrading it to Odoo 18? Can we sponsor this?