search

OCA / server-brand

GNU Affero General Public License v3.0
58 stars 149 forks source link

[14.0][ADD] add module to remove app download links #72

Closed PicchiSeba closed 1 year ago

PicchiSeba commented 1 year ago

Proposal for a module to disable the Odoo Enterprise app download window when no expenses have been registered

Before: Screenshot from 2023-03-27 15-54-24

After: Screenshot from 2023-03-27 15-52-48

I think this could be an interesting addition to the de-brand options. This module only depends on the hr_expense module, which is also the reason why it wasn't included in previously available de-brand modules.

PicchiSeba commented 1 year ago

pre-commit error doesn't seem to be related to my changes, can anyone confirm?

PicchiSeba commented 1 year ago

I applied the suggested fixes but the error seems to be the same as before. I guess we'll have to wait.

aleuffre commented 1 year ago

I agree with the rename to hr_expense_remove_mobile_link

Otherwise, looks good!

Will approve after the name change.

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

aleuffre commented 1 year ago

@OCA/brand-maintainers

thomaspaulb commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-72-by-thomaspaulb-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at e9df384a5934f85d3b2dc0e22e5178aeab5db6ff. Thanks a lot for contributing to OCA. ❤️

astirpe commented 1 year ago

@PicchiSeba will you also port this module to V15 and V16?

PicchiSeba commented 1 year ago

@astirpe Yes