[17.0][MIG] remove_odoo_enterprise: Migration to 17.0

[vincent-hatakeyama]

Some features are not working correctly:

• in apps, all the odoo enterprise modules are still displayed.

The feature that work are:

• removal of the enterprise features from settings
• the app stores button is removed

[remi-filament]

You are right @vincent-hatakeyama , thank you for checking that ! Sorry, I did not spotted it locally, since I realize to_buy modules where removed from my local database...

Web client does not use search() function anymore but web_search_read (since https://github.com/odoo/odoo/pull/114024 and web_search_read was first added as unity_web_search_read with https://github.com/odoo/odoo/pull/119034)

Here, I asked myself whether we should override web_search_read or search_fetch as you propose, and I chose the second one so that it has broader impact than just on the web interface. Also, I merged the check done for payment provider and ir_module_module in the same base.py file since having it in 2 different places causes 2 overrides when searching in ir_module_module.

[carolinafernandez-tecnativa]

Functional review LGTM, could you please squash administrative commits? Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for further information

[carolinafernandez-tecnativa]

Hi! Can you check my comment before ? so we can move forward with this migration :) Thanks!

[remi-filament]

Thanks for your review @carolinafernandez-tecnativa I have squashed bot commits.

[carolinafernandez-tecnativa]

@pedrobaeza do you think that can we proceed to merge?

[carolinafernandez-tecnativa]

@remi-filament just a little comment, please rename PR with OCA conventions. It should be named [17.0][MIG] <module>: Migration to 17.0.

Check this https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0 for further information.

[pedrobaeza]

/ocabot migration remove_odoo_enterprise /ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-83-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 8e433fccb40e355053b1d29cc23933ca1c7fe877. Thanks a lot for contributing to OCA. ❤️