[16.0][FIX] mail_environment: add search field for fetchmail.server's is_ssl

[StefanRijnhart]

Fixes

while parsing /home/odoo/16.0/addons/mail/views/fetchmail_views.xml:88
Error while validating view near:

                    <separator/>
                    <filter string="SSL" name="ssl" domain="[('is_ssl', '=', True)]" help="If SSL required."/>
                    <separator/>
                    <filter string="Archived" name="inactive" domain="[('active', '=', False)]"/>
                </search>
Unsearchable field 'is_ssl' in path 'is_ssl' in domain of <filter name="ssl"> ([('is_ssl', '=', True)]))

While upgrading --all on a setup with mail_environment installed.

[florian-dacosta]

thanks for the fix There is small pre-commit issue. About the test, I am no expert, but IMHO just a small test doing a search with the is_ssl field in the domain and checking the result is correct would be more than enough.

[StefanRijnhart]

@florian-dacosta Thanks! Indeed, we just want to test the search method but I had to figure out how to add a server environment configuration test (and how any of this works in the first place). Now proud to add the first tests in this module!

[rven]

Could someone merge this?

[florian-dacosta]

@simahawk @etobella possible to merge this one?

[simahawk]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-134-by-simahawk-bump-patch, awaiting test results.

[OCA-git-bot]

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-134-by-simahawk-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[OCA-git-bot]

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-134-by-simahawk-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[StefanRijnhart]

Pre-commit fixed in https://github.com/OCA/server-env/pull/148

[bguillot]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-134-by-bguillot-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 087df5888ce77d4c209b7ac3c317d1514615abd0. Thanks a lot for contributing to OCA. ❤️