OCA / server-env

Tools to manage environment-dependent configuration
GNU Affero General Public License v3.0
56 stars 149 forks source link

[15.0] auth_saml_environment: removes readonly attributes to allow provider creation #177

Closed StephaneMangin closed 1 week ago

StephaneMangin commented 6 months ago

Some readonly fields prevent the creation of a provider. Removing them as they will be managed by the env.

Following change in https://github.com/OCA/server-auth/pull/342

(edit @yvaucher adding link to the source of the issue)

yvaucher commented 5 months ago

You don't want to state the odoo version in the commit message but rather the type of change. The odoo version is to be mentionned in the title of the PR.

Can you replace the content of the commit message by:

    [FIX] auth_saml_environment: no require on readonly fields

    Restore the usage of the form view by dropping the required condition on
    binary fields that are readonly.

    Those fields became mandatory after https://github.com/OCA/server-auth/pull/342
    but the module auth_saml_environment offer to use paths as a alternative config
    option for binaries thus those fields can be empty.
yvaucher commented 5 months ago

Backported here https://github.com/OCA/server-env/pull/179

vincent-hatakeyama commented 5 months ago

idp_metadata is required for a provider to work. In a similar way, the server hostname of an outgoing server is mandatory. mail_environment does not change smtp_host to be optional, so I do not see why this module would do so for idp_metadata.

For sp_pem_public and and sp_pem_private, I would recommend fixing issue OCA/server-auth/issues/315 in auth_saml that made me change them to mandatory rather than adding another level of work around.

github-actions[bot] commented 1 month ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.