search

OCA / server-env

Tools to manage environment-dependent configuration
GNU Affero General Public License v3.0
56 stars 149 forks source link

[FIX] mail_environment: default computation #194

Closed gurneyalex closed 2 months ago

gurneyalex commented 2 months ago

fix the implementation of _compute_default_authentication to match what is expected by the mixin

gurneyalex commented 2 months ago

/ocabot merge patch

OCA-git-bot commented 2 months ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch, awaiting test results.

OCA-git-bot commented 2 months ago

@gurneyalex The merge process could not start, because command git push origin :15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch failed with output:

To https://github.com/OCA/server-env
 ! [remote rejected] 15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch (cannot lock ref 'refs/heads/15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch': unable to resolve reference 'refs/heads/15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch')
error: failed to push some refs to 'https://***@github.com/OCA/server-env'
OCA-git-bot commented 2 months ago

@gurneyalex The merge process could not be finalized, because command git push origin :15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch failed with output:

To https://github.com/OCA/server-env
 ! [remote rejected] 15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch (cannot lock ref 'refs/heads/15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch': unable to resolve reference 'refs/heads/15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch')
error: failed to push some refs to 'https://***@github.com/OCA/server-env'
OCA-git-bot commented 2 months ago

It looks like something changed on 15.0 in the meantime. Let me try again (no action is required from you). Prepared branch 15.0-ocabot-merge-pr-194-by-gurneyalex-bump-patch, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at b6963c5cf8cb86caac6bd38349d8f7489b74289a. Thanks a lot for contributing to OCA. ❤️