[18.0][MIG] server_environment from 17.0

[sbidoul]

First 18.0 PR to test the project template.

• I also add the ruff config improvements: https://github.com/OCA/oca-addons-repo-template/pull/273
• ~the xml prettifier improvements: https://github.com/OCA/oca-addons-repo-template/issues/224~

[sbidoul]

@moylop260 can you help with the po-pretty-format issue here? I don't understand what the error means.

[sbidoul]

The other issue is that the current .eslintrc.yml is not compatible with the latest eslint, and eslint-precommit does not seem to work well with pre-commit...

[rousseldenis]

@moylop260 can you help with the po-pretty-format issue here? I don't understand what the error means.

Currently on it.

Try regenerating .pot file.

[SirAionTech]

The other issue is that the current .eslintrc.yml is not compatible with the latest eslint, and eslint-precommit does not seem to work well with pre-commit...

Try including https://github.com/SirAionTech/server-env/commit/d8e1926a14faa9b2a2c88a9f41f7cd5e3e73d489; I'll try to include it in the addons repo template in the next few days or more probably after the experience

[sbidoul]

@SirAionTech I worry that this adds additional dependencies that are not pinned.

I don't know, if we don't find a good solution soon, we'll start with the same eslint version as in 17. And we then have a year to modernize..

[sbidoul]

:green_apple:

[sbidoul]

Don't merge just yet, I need to restart the bot.

[sbidoul]

Ok, bot is ready.

[moylop260]

@sbidoul

@moylop260 can you help with the po-pretty-format issue here? I don't understand what the error means.

Checking...

[moylop260]

@sbidoul

It needs the following args in order to autofix it:

 - repo: https://github.com/OCA/odoo-pre-commit-hooks
     rev: v0.0.33
     hooks:
       - id: oca-checks-odoo-module
       - id: oca-checks-po
+        args:
+          - --fix

OFFTOPIC: BTW I will show the diff if the parameter is not defined for wrong-format

UPDATED: https://github.com/OCA/odoo-pre-commit-hooks/issues/110

UPDATED2: Agree disabling it https://github.com/OCA/oca-addons-repo-template/pull/274

[pedrobaeza]

/ocabot migration server_environment

[OCA-git-bot]

There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment.

[pedrobaeza]

The pre-commit auto-fixes commit is after the migration commit, but not being critical, let's try to merge the module to see if any problem:

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 18.0-ocabot-merge-pr-204-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 3ddab3000be3f3fdcbdf78851fe66666eb85bcfc. Thanks a lot for contributing to OCA. ❤️