OCA / server-env

Tools to manage environment-dependent configuration
GNU Affero General Public License v3.0
57 stars 162 forks source link

[12.0] fix server environmnet ir config parameter security issues #68

Closed legalsylvain closed 2 years ago

legalsylvain commented 4 years ago

Hi all.

[x] Display database / environment parameters clearly. [x] avoid to display production values in testing environment. [x] improve documentation regarding that points.

ir_config_parameter_tree

closes: #25

Waiting for : #67. Please do not review the first commit.

@sbidoul : i finally didn't implemented your "maybe proposal" posted here. "Maybe you could log an error if read is called (unless a specific context key is set) so we at least have a way to spot such cases ?" The reason is that my PR doesn't introduce bugs. In fact, if you :

Note : Do not review for the time being, tests are failing.

legalsylvain commented 4 years ago

Now green. some simplification. Note : I think that server_environment_ir_config_parameter should not depends on server_environment as it is working without and it has sense. but another story.

github-actions[bot] commented 3 years ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.