search

OCA / server-env

Tools to manage environment-dependent configuration
GNU Affero General Public License v3.0
57 stars 157 forks source link

[13.0] Improvements on server.env.techname.mixin #75

Closed ivantodorovich closed 2 years ago

ivantodorovich commented 3 years ago

ping @simahawk

What do you think about this?

Re. the mixin inherit (https://github.com/OCA/server-env/commit/154090abb7a694948c2ff9a9b6809abdd85a8c0b), I guess it wasn't done like this before because one may use server.env.techname.mixin without server.env.mixing but I can't see why one would want to do that.. I find this way easier to use and in most cases saves a few line breaks

simahawk commented 3 years ago

@ivantodorovich could you test this on OCA/search-engine ?

simahawk commented 2 years ago

@ivantodorovich ping :)

ivantodorovich commented 2 years ago

@ivantodorovich could you test this on OCA/search-engine ?

It seems ok Is there something specific you have in mind?

simahawk commented 2 years ago

just use this change there and see if you get a green build ;)

ivantodorovich commented 2 years ago

just use this change there and see if you get a green build ;)

Indeed it's not working.

connecto_search_engine would need to be adapted to have the index_prefix_name in a computed field.

But also I tried that, and it's not working as expected. Since server_environment "transforms" fields into computed fields to read from config. I created this issue to explain it: https://github.com/OCA/server-env/issues/85

I couldn't find a simple solution for now :/ so best if we close this and reevaluate in a future migration IMO

simahawk commented 1 year ago

@ivantodorovich you can reconsider this here https://github.com/OCA/server-env/pull/122 :wink: