Closed ivantodorovich closed 3 years ago
I have no idea why originally it was GPL, but AFAIR this module dates from OpenERP 5.0, which was GPL. Considering
Adapted by Nicolas Bessi. Copyright Camptocamp SA Based on Florent Xicluna original code. Copyright Wingo SA
I suppose @nbessi and @florentx (hi!) may know better than me if we can change the license :) Apparently, the code that goes back from the original module is mainly the one that generates the view dynamically https://github.com/OCA/server-env/blob/314d16d37c8ce56603c3d1ad9c2ff596d1f22425/server_environment/server_env.py#L176-L315 and system info https://github.com/OCA/server-env/blob/314d16d37c8ce56603c3d1ad9c2ff596d1f22425/server_environment/system_info.py
Purely for historical reason. Fine for me we can move to LGPL.
/ocabot merge major
This PR looks fantastic, let's merge it! Prepared branch 13.0-ocabot-merge-pr-77-by-simahawk-bump-major, awaiting test results.
Congratulations, your PR was merged at 7a07aa2d493f5cdb39ab7c2692681495157fe9ca. Thanks a lot for contributing to OCA. ❤️
ping @simahawk @guewen
Following up on your comment here: https://github.com/OCA/server-env/pull/76#discussion_r664276443
Would you mind point out what you saw? If it's indeed LGPL what we need here, do we also need to change the license of the modules that depend on it?
Also what about this file? If it's based on someone else's work I don't think we can change it, right? https://github.com/OCA/server-env/blob/314d16d37c8ce56603c3d1ad9c2ff596d1f22425/server_environment/server_env.py#L1-L19