search

OCA / server-env

Tools to manage environment-dependent configuration
GNU Affero General Public License v3.0
57 stars 157 forks source link

[REF] .t2d.yml: Fix runbot red #88

Closed moylop260 closed 2 years ago

moylop260 commented 2 years ago

Docker image used from runbot is too old So it is using python3.7 as last python version installed But only 4.5.4 coverage version is supported by this version of py

pedrobaeza commented 2 years ago

But this problem is going to be present on all 15.0 branches, as we want to use Python 3.8 on them. Can we bump the travis2docker version instead?

gurneyalex commented 2 years ago

But this problem is going to be present on all 15.0 branches, as we want to use Python 3.8 on them. Can we bump the travis2docker version instead?

FWIU the issue is more in the base docker image we use to run things on, which does not have python3.8 available.

I think it would be a very good idea to upgrade it, esp. since it uses a very old Ubuntu as base version (see https://github.com/Vauxoo/docker-ubuntu-base/blob/master/Dockerfile)

pedrobaeza commented 2 years ago

Or maybe we can use new runbot docker system directly.

moylop260 commented 2 years ago

Both ideas are good

This PR is only a quick workaround in order to have the runbot v15.0 branches green ASAP

I'm not able to work on this right now

But feel free to take this job to use a newer global image or using runbot based on docker images

It could be great!

moylop260 commented 2 years ago

BTW runbot is green now for this project:

cc @sbidoul @Yajo

gurneyalex commented 2 years ago

@sbidoul do you think we could relax the python version requirements on the pypi published packages to >= 3.7 ?

sbidoul commented 2 years ago

Now that Odoo finally says >= 3.7, I think we can, but we should then also test on python 3.7 on the OCA CI.

sbidoul commented 2 years ago

The discussion that led to chosing 3.8 is in https://github.com/OCA/oca-addons-repo-template/pull/70 (in the resolved comments)

gurneyalex commented 2 years ago

Now that Odoo finally says >= 3.7, I think we can, but we should then also test on python 3.7 on the OCA CI.

we would, at least with runbot, have 3.7. So you mean changing the github actions setup to use 3.7 too?

sbidoul commented 2 years ago

I created https://github.com/OCA/oca-addons-repo-template/pull/84 and friends to test on 3.7.

github-actions[bot] commented 2 years ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.