search

OCA / server-env

Tools to manage environment-dependent configuration
GNU Affero General Public License v3.0
57 stars 157 forks source link

[14.0][ADD] server_environment_iap: to override IAP Accounts from server environment file #97

Closed yankinmax closed 2 years ago

yankinmax commented 2 years ago

It would be nice to set IAP Accounts in the server environment file, possibly make their key and value readonly in the user interface and remove them from the database except for production.

yankinmax commented 2 years ago

@gurneyalex take a look pls here. Is my workflow correct?

gurneyalex commented 2 years ago

@yankinmax any reason not to use the server.environment.mixin? (see https://github.com/OCA/server-env/blob/14.0/server_environment/models/server_env_mixin.py for the documentation)

github-actions[bot] commented 2 years ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

gurneyalex commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-97-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-97-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at 680065b50346c62ab0c60c7318354c224d112b26. Thanks a lot for contributing to OCA. ❤️