OCA-git-bot commented 5 years ago

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

[ ] 13 - By @NL66278 - #1933
[x] auditlog - ~~By @lembregtse - #1685~~ By @sebalix - #1793
[ ] auto_backup - By @jcarlosmontoya - #1697
[ ] base_cron_exclusion
[ ] base_custom_info - By @dalonsod - #1833
[x] base_exception - ~~By @jaredkipe - #1760~~ By @joao-p-marques - #1920
[ ] base_fontawesome
[ ] base_force_record_noupdate - By @vvrossem - #2954
[x] base_import_odoo - By @hbrunn - #1948
[x] base_jsonify By @Laurent-Corron #1704
[ ] base_search_fuzzy
[ ] base_technical_user
[x] base_view_inheritance_extension - By @sergio-teruel - #1779
[ ] database_cleanup - By @newtratip - #1745
[x] datetime_formatter - By @victoralmau - #2029
[ ] dbfilter_from_header - By @newtratip - #1682
[ ] excel_import_export - By @kittiu - #1684
[ ] excel_import_export_demo - By @kittiu - #1684
[ ] fetchmail_notify_error_to_sender
[x] html_image_url_extractor - By @victoralmau - #2030
[x] html_text - By @victoralmau - #2027
[ ] module_analysis
[ ] module_auto_update
[ ] nsca_client - By @etobella - #2111
[x] onchange_helper
[x] scheduler_error_mailer - By @victoralmau - #2260
[ ] sentry
[ ] sql_export
[ ] sql_request_abstract

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

lembregtse commented 5 years ago

Will be working on migration of auditlog (https://github.com/OCA/server-tools/pull/1685)

newtratip commented 5 years ago

I'm working on dbfilter_from_header

kittiu commented 5 years ago

Work on excel_import_export and excel_import_export_demo

schout-it commented 5 years ago

working on module_auto_update

gurneyalex commented 5 years ago

anyone knows if onchange_helper still makes sense in 13.0 ? I guess yes because api.onchange is still around

pedrobaeza commented 5 years ago

Yes, it's needed as most code still uses it

Laurent-Corron commented 5 years ago

working on:

base_jsonify #1704
onchange_helper #1705

ghost commented 4 years ago

Can anyone work on base_exception ?

LoisRForgeFlow commented 4 years ago

base_cron_exclusion done in #1746.

ghost commented 4 years ago

base_custom_info don't get upgrade?

AMhadhbi commented 4 years ago

scheduler_error_mailer done in #1772.

IvanShirokikh commented 4 years ago

working on sentry #1776

newtratip commented 4 years ago

dbfilter_from_header #1781 supersedes #1682

newtratip commented 4 years ago

I'm working on html_text https://github.com/OCA/server-tools/pull/1782

ghost commented 4 years ago

working in sql_request_abstract & sql_export #1783

ghost commented 4 years ago

hi, after migrating sql_export ,I want to add live preview feature using pivot table widget. anyone interested?

codeagencybe commented 4 years ago

@IvanShirokikh Is there any ETA when v13 for Sentry would be available? Anything I can help with? beta test?

Thanks!

luisg123v commented 4 years ago

Hi,

It seems this list needs some updates:

base_cron_exclusion: already done by @LoisRForgeFlow on https://github.com/OCA/server-tools/pull/1746
dbfilter_from_header: current PR superseded by https://github.com/OCA/server-tools/pull/1781
html_text: in progress by @newtratip on https://github.com/OCA/server-tools/pull/1782
onchange_helper: missing PR (https://github.com/OCA/server-tools/pull/1705)
scheduler_error_mailer: in progress by @AMhadhbi on https://github.com/OCA/server-tools/pull/1772
sentry: in progress by @IvanShirokikh on https://github.com/OCA/server-tools/pull/1776
sql_request_abstract: in progress by @alfadil on https://github.com/OCA/server-tools/pull/1783

luisg123v commented 4 years ago

company_country done by @moylop260 on https://github.com/OCA/server-tools/pull/1723

yaazkal commented 4 years ago

Hi, is there any ETA for dbfilter_from_header I see the PR is still open, maybe not ready yet?

luisg123v commented 4 years ago

@yaazkal maybe you should ask/offer help on the opened PR instead?

newtratip commented 4 years ago

Hi @yaazkal dbfilter_from_header is done now, Could you help to review ?

IvanShirokikh commented 4 years ago

@codeagencybe, Hi, PR on review, I don't know if it can be done faster

yaazkal commented 4 years ago

@luisg123v @newtratip thanks so much for your answers.

I'll test the PR and leave a comment there, forgive me the noise that I made here if that had corrupted this issue.

Have a nice day !

okuryan commented 4 years ago

@pedrobaeza ,we are working on migrating fetchmail_notify_error_to_sender

We have already migrated it. But problem we are having specifically with test_mail module. In Odoo 12 we are inheriting tests from TestMailgateway class. See here https://github.com/OCA/server-tools/blob/12.0/fetchmail_notify_error_to_sender/tests/test_fetchmail_notify_error_to_sender.py#L10

In Odoo 11 we were inheriting tests from TestMail class. See here https://github.com/OCA/server-tools/blob/11.0/fetchmail_notify_error_to_sender/tests/test_fetchmail_notify_error_to_sender.py#L10

Now problem we are facing is that if we do like in Odoo 12 (inherit from TestMailgateway) standard Odoo tests are failing. For example this one on exactly this line https://github.com/odoo/odoo/blob/13.0/addons/test_mail/tests/test_mail_gateway.py#L335

Logically we thought - wow, we broken tests for emails. SO we run this test without our migrated module and EXACTLY this amount of tests also were failing. Be specifically the following test:

test_message_process_alias_followers_bounce
test_message_process_alias_followers_partners_bounce
test_message_process_write_to_catchall
test_message_process_alias_update

We tried to return back to old method like in Odoo 11 of inheriting from TestMail, and after some adjustments of course test is working.

But we have feeling that it is not right to inherit from TestMail as we are really making changes to gateway behavior. So inheriting from TestMailgateway sounds like proper way.

Has anybody faced same issues?

pedrobaeza commented 4 years ago

Sorry, I can't say as I don't know that one.

okuryan commented 4 years ago

@MiquelRForgeFlow I have seen you was working previously on another module fetchmail_incoming_log Maybe you faced similar issues as I described above?

MiquelRForgeFlow commented 4 years ago

@okuryan I will check later, but your message above says about v12, not v13, or is it an error?

okuryan commented 4 years ago

@MiquelRForgeFlow in message above I'm saying that when I run standard Odoo 13 tests from test_mail - they fail. While in Odoo 12 same tests worked.

So I'm wondering either problem is really with Odoo 13 Standard having not working tests. Or we are writing/running tests incorrectly for Odoo 13 mail functionality testing.

okuryan commented 4 years ago

@MiquelRForgeFlow , could you, please, do code review from your side of this pull request? https://github.com/OCA/server-tools/pull/1815

I think on OCA infrastructure we do not have issues with tests described above.

@pedrobaeza , you are also welcome to participate in code review :)

MiquelRForgeFlow commented 4 years ago

@okuryan fetchmail_incoming_log done in https://github.com/OCA/server-tools/pull/1820 😉

okuryan commented 4 years ago

@MiquelRForgeFlow nice, see it is already approved! =) And also our fetchmail_notify_error_to_sender merge request already reviewed and ready to be merged. https://github.com/OCA/server-tools/pull/1815