OCA / server-tools

Tools for Odoo Administrators to improve some technical features on Odoo.
https://odoo-community.org/psc-teams/tools-30
GNU Affero General Public License v3.0
704 stars 1.5k forks source link

Migration to version 14.0 #1910

Open OCA-git-bot opened 4 years ago

OCA-git-bot commented 4 years ago

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

chafique-delli commented 4 years ago

base_jsonify here https://github.com/OCA/server-tools/pull/1911

alan196 commented 4 years ago

auditlog here https://github.com/OCA/server-tools/pull/1919

traviswaelbro commented 4 years ago

sentry here #1929

manengel commented 4 years ago

I will migrate module_auto_update.

manengel commented 4 years ago

module_auto_update #1943 (Work in Progress)

chafique-delli commented 3 years ago

scheduler_error_mailer here https://github.com/OCA/server-tools/pull/1979

santostelmo commented 3 years ago

module_analysis here https://github.com/OCA/server-tools/pull/1982

dzungtran89 commented 3 years ago

base_time_window #1988

StephaneMangin commented 3 years ago

database_cleanup https://github.com/OCA/server-tools/pull/1990

hparfr commented 3 years ago

base_m2m_custom_field #1992

eantones commented 3 years ago

dbfilter_from_header https://github.com/OCA/server-tools/pull/2007

manengel commented 3 years ago

module_auto_update #1943 done so far

SimoRubi commented 3 years ago

base_report_auto_create_qweb https://github.com/OCA/server-tools/pull/2045

petrus-v commented 3 years ago

mail_server_relay_disallowed #2051

bosd commented 3 years ago

please add: base_multi_image

hailangvn commented 3 years ago

base_multi_image: WIP https://github.com/OCA/server-tools/pull/2083

hkapatel-initos commented 3 years ago

html_text: migrated #2090

hkapatel-initos commented 3 years ago

I will migrate module fetchmail_incoming_log #2095

hkapatel-initos commented 3 years ago

I will migrate module fetchmail_notify_error_to_sender #2102

moylop260 commented 3 years ago

@hkapatel-initos

I think the module companycountry is not required anymore in v14.0 Since that now it validates if there is an `l10n` to install

@luisg123v Could you confirm, please?

luisg123v commented 3 years ago

@moylop260 @hkapatel-initos,

That's correct, company_country is not required anymore, check the README and the discussion on https://github.com/OCA/server-tools/pull/1872#pullrequestreview-460702345

hkapatel-initos commented 3 years ago

@hkapatel-initos

I think the module companycountry is not required anymore in v14.0 Since that now it validates if there is an `l10n` to install

@luisg123v Could you confirm, please?

Yes, i saw it . thank you

hkapatel-initos commented 3 years ago

I will migrate module sql_export_mail #2107

hkapatel-initos commented 3 years ago

I will migrate module sql_export_excel #2115

hkapatel-initos commented 3 years ago

I will migrate module base_kanban_stage #2117

hkapatel-initos commented 3 years ago

i will migrate module base_kanban_stage_state #2119

fshah-initos commented 3 years ago

I'll migrate the module 'base_remote' .

dsolanki-initos commented 3 years ago

I'll migrate the module ''datetime_formatter"

hkapatel-initos commented 3 years ago

I'll migrate the module "test_base_time_window" #2122

dsolanki-initos commented 3 years ago

I'll migrate the module 'base_changeset' to v14.

hkapatel-initos commented 3 years ago

i will migrate the module 'html_image_url_extractor' #2127

fredzamoabg commented 3 years ago

created new PR (https://github.com/OCA/server-tools/pull/2136) for porting of scheduler_error_mailer module.

randall-vx commented 3 years ago

Working on attachment_unindex_content #2140

cc: @moylop260 @luisg123v

ska-ibees commented 3 years ago

Any reason that base_custom_info module is not in the list?

pedrobaeza commented 3 years ago

See the last line in the main comment

ska-ibees commented 3 years ago

Yes I checked that link and I commented here after reading last line on that page "You can ask in the issue itself for the module to be added to the list if you detect that is missing."

pedrobaeza commented 3 years ago

But are you going to work on such migration?

ska-ibees commented 3 years ago

Yes, I can do it. Just wanted to confirm the reason of not bieng in the list e.g. may be not required due to features availablein core etc.

ska-ibees commented 3 years ago

Also, while migration is it ok to add our name in the author list? I am using Doodba so it is mandatory to pass pre-commit.

pedrobaeza commented 3 years ago

Doodba has nothing to do with pre-commit requirement. Although working with Doodba, you can repositories not subjected to pre-commit (example, 12.0 OCA repositories). No, author list is reserved to a significant contribution, which migration work is not usually such thing. You can to the contributors list though.

ska-ibees commented 3 years ago

Alright, let me re-visit my configurations. There is always [C8101(manifest-required-author), ] asking me to add value that was given for project_author in copier answers. Further, if not resolved I will open an issue on Doodba repo iteself.

Anyways, thanks for your usual prompt response.

pedrobaeza commented 3 years ago

Copier is for the Doodba project scaffolding, not for modules. Check the module migration guide linked in the top comment.

ska-ibees commented 3 years ago

Offcourse, module migration is independent of Doodba or copier. Infact I am following your procedure from OCA days where you demostrated a live module migration using Doodba. And everytime I perform pre-commit it throws [C8101(manifest-required-author), ]. I think i should better exclude OCA migration repos from pre-commit.

pedrobaeza commented 3 years ago

Uhm, but that error is correct: you should add in the manifest an author, and for OCA repos, it should include also OCA (Odoo Community Association) as co-author. Maybe you missed the comma for separating authors?

ska-ibees commented 3 years ago

Yes, OCA (Odoo Community Association) is already there in all OCA modules. But I get below error:

***** Module base_custom_info.manifest odoo/custom/src/private/base_custom_info/manifest.py:6: [C8101(manifest-required-author), ] One of the following authors must be present in manifest: 'iBees'

Where iBees is the author that is coming from project_author: iBees in .copier-answers.yml

ska-ibees commented 3 years ago

Now I see, pre-commit is also one of the migration steps. So, can't just exclude it from pre-commit.

pedrobaeza commented 3 years ago

It seems you are migrating the module inside private folder, and not on its repo folder, where specific pre-commit configuration is on place.

ska-ibees commented 3 years ago

Well spotted :clap:

hkapatel-initos commented 3 years ago

i will migrate the module 'autovacuum_message_attachment' to v14

kittiu commented 3 years ago

Hello, I am working on base_custom_info https://github.com/OCA/server-tools/pull/2143