[7.0] Sentry logger DSN warning

[rousseldenis]

@gurneyalex Can you change DSN warning as runbot environnment changed ?

[gurneyalex]

@rousseldenis can you be more specific?

[rousseldenis]

@gurneyalex Ok. In sentry_logger module, you added a test if in runbot environment not to have warning. (see commit e386b31378544f1b7410c62dd4fbcbd81d5d7196)

As runbot environnment has changed, the test fails now.

[gurneyalex]

Hmmm I had forgotten about this.

@moylop260 do you know if there is an environment variable we can use as of now in the docker runbot builds to achieve the same result?

[moylop260]

I'll review it...

[lasley]

What about the SERVER_OPTIONS created for Runbot to send in the log db? We'd at least only need to update the addon vs. further up the depends chain. In hindsight, I probably should have abstracted that a bit better so we could inherit and update.

[moylop260]

I got it We need a environment variable called OCA_CI to detect a runbot build and skip this error from here

Currently we are using OCA_RUNBOT from our base image to detect runbot builds.

We have 2 options:

1. Change server-tools to skip with OCA_RUNBOT instead of OCA_CI
2. Add OCA_CI to base image

I don't know what is the better but I'll create a PR with the option 1

[moylop260]

@lasley Your idea is good to add dynamic values from -e ENVIRONMENT_VARIABLE=value Am right?

For this case we need a simple flag like as

• https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables

In order to detect a particular environment

[moylop260]

FYI https://github.com/OCA/server-tools/pull/632

[lasley]

Yup you're right @moylop260 - I wasn't fully understanding the issue.

[github-actions[bot]]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.