Closed CRogos closed 4 months ago
/ocabot migration server_action_mass_edit /ocabot merge nobump
This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-872-by-pedrobaeza-bump-nobump, awaiting test results.
@pedrobaeza The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-ux --branch 17.0 --addons-dir /tmp/tmp6j8hyqym --commit
failed with output:
/tmp/tmp6j8hyqym/server_action_mass_edit/README.rst:95: (ERROR/3) Duplicate substitution definition name: "image".
Traceback (most recent call last):
File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
return self.main(*args, **kwargs)
File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/ocamt/lib/python3.8/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
check_rst(readme_filename)
File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
publish_file(
File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 422, in publish_file
output, publisher = publish_programmatically(
File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 722, in publish_programmatically
output = publisher.publish(enable_exit_status=enable_exit_status)
File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 234, in publish
self.document = self.reader.read(self.source, self.parser,
File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 70, in read
self.parse()
File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 76, in parse
self.parser.parse(self.input, document)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
self.statemachine.run(inputlines, document, inliner=self.inliner)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 169, in run
results = StateMachineWS.run(self, input_lines, input_offset,
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
context, next_state, result = self.check_line(
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
return method(match, context, next_state)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 3024, in text
self.section(title.lstrip(), source, style, lineno + 1, messages)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
self.new_subsection(title, lineno, messages)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
newabsoffset = self.nested_parse(
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
state_machine.run(block, input_offset, memo=self.memo,
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
results = StateMachineWS.run(self, input_lines, input_offset)
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
context, next_state, result = self.check_line(
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
return method(match, context, next_state)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2785, in underline
self.section(title, source, style, lineno - 1, messages)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
self.new_subsection(title, lineno, messages)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
newabsoffset = self.nested_parse(
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
state_machine.run(block, input_offset, memo=self.memo,
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
results = StateMachineWS.run(self, input_lines, input_offset)
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
context, next_state, result = self.check_line(
File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
return method(match, context, next_state)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2355, in explicit_markup
nodelist, blank_finish = self.explicit_construct(match)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2367, in explicit_construct
return method(self, expmatch)
File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2085, in substitution_def
self.document.note_substitution_def(
File "/ocamt/lib/python3.8/site-packages/docutils/nodes.py", line 1550, in note_substitution_def
msg = self.reporter.error(
File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 231, in error
return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 197, in system_message
raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmp6j8hyqym/server_action_mass_edit/README.rst:95: (ERROR/3) Duplicate substitution definition name: "image".
@CRogos please fix the readme references
@pedrobaeza could you retry
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-872-by-pedrobaeza-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 57e1c9492731755e655454d5f0079c7843dc5a43. Thanks a lot for contributing to OCA. ❤️
followup #838
@rov-adhoc something got mixed up in your commit history. Maybe you merged into your migration branch instead of rebase it? I've created a new branch and picked your last commit.
There were also some more commits to cleanup. Here you can see, what should have been sqashed together: