OCA / server-ux

GNU Affero General Public License v3.0
158 stars 514 forks source link

[16.0][FIX] base_cancel_confirm: correct get_view method #898

Closed JordiMForgeFlow closed 2 months ago

JordiMForgeFlow commented 2 months ago
OCA-git-bot commented 2 months ago

Hi @kittiu, some modules you are maintaining are being modified, check this out!

JordiMForgeFlow commented 2 months ago

@aliciagaarzo I can see you made these changes in the migration to v16: https://github.com/OCA/server-ux/pull/661/commits/8edbb21c58ac4f2d45ba7d09867f1f670c234f1e

Why did you changed it like this?

I am trying to add a module for the account move (https://github.com/OCA/account-invoicing/pull/1744) but with the changes you added in V16 the view gets broken:

image

I am trying to align with similar implementations in the OCA.

JordiMForgeFlow commented 2 months ago

@kittiu @hugo-cordoba could you look into this one?

JordiMForgeFlow commented 2 months ago

CC @OCA/tools-maintainers

thomaspaulb commented 2 months ago

/ocabot merge patch

OCA-git-bot commented 2 months ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-898-by-thomaspaulb-bump-patch, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 7b9c32acf3afd014bda3488c4530d83c21061d9b. Thanks a lot for contributing to OCA. ❤️