OCA / server-ux

GNU Affero General Public License v3.0
163 stars 531 forks source link

[MIG] base_tier_validation_forward: Migration to 17.0 #912

Closed denaux closed 3 months ago

LoisRForgeFlow commented 3 months ago

@denaux could you include this fix from 16.0 here https://github.com/OCA/server-ux/pull/930 ?

denaux commented 3 months ago

@LoisRForgeFlow thanks for the heads-up. I've included the fix.

bosd commented 3 months ago

Code review, LGTM. 👍 There is a warning message..

WARNING odoo odoo.addons.base.models.ir_model: Rule access.tier.validation.forward.wizard has no group, this is a deprecated feature. Every access-granting rule should specify a group. 
denaux commented 3 months ago

@bosd good catch. I've added the base.group_user to the rule in the security file.

LoisRForgeFlow commented 3 months ago

/ocabot migration base_tier_validation_forward

/ocabot merge nobump

OCA-git-bot commented 3 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-912-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 1125540b962a5cde61ff7290b8c5a5f58c6e569c. Thanks a lot for contributing to OCA. ❤️