search

OCA / server-ux

GNU Affero General Public License v3.0
158 stars 514 forks source link

[16.0][IMP] base_tier_validation: Change _compute_need_validation() #928

Open BernatPForgeFlow opened 1 month ago

BernatPForgeFlow commented 1 month ago

A document does not need validation only if there are no pending reviews, otherwise we should evaluate as True. We add a condition in request_validation to be able to request more than one time if there are new tier validations.

OCA-git-bot commented 1 month ago

Hi @LoisRForgeFlow, some modules you are maintaining are being modified, check this out!

StefanRijnhart commented 2 weeks ago

Would you consider adding a test to demonstrate what this effectively changes in the flow?

StefanRijnhart commented 1 week ago

Thanks for the update. Do I understand correctly that the commit message may be updated to say 

more than one time if there are new tier definitions

rather than new tier validations?

OCA-git-bot commented 1 week ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖