search

OCA / server-ux

GNU Affero General Public License v3.0
163 stars 532 forks source link

[17.0][MIG] base_export_manager: Migration to 17.0 #929

Open david-s73 opened 4 months ago

benjilluch commented 1 month ago

Hello, this PR has been stuck for a while. Is there anything I can do to help unblock it? From what I see, the test coverage doesn't meet the expected threshold. Is it really necessary?

chienandalu commented 1 month ago

Coverage isn't blocking. It simply has no reviewers

benjilluch commented 1 month ago

I’m sorry to hear that there aren’t any reviewers assigned. If I can help, I’d be happy to assist!

chienandalu commented 1 month ago

There's no need to assign reviewers, anyone can do it any time. You can ask the contributor for a re-push that triggers the runboat again to be able to test the funcionallity and you can do a full review in the context of the new version.

benjilluch commented 1 month ago

@david-s73 Could you please do a re-push to trigger the runboat again? That way I can test the functionality and perform a full review on the latest version. Thanks!

david-s73 commented 1 month ago

@benjilluch Done

benjilluch commented 1 month ago

I’ve just tested it on Runboat, and it works well.

benjilluch commented 1 month ago

@chienandalu Could I ask if anything else is needed on this?

benjilluch commented 1 month ago

@pedrobaeza Can you look into speeding up this issue?

pedrobaeza commented 1 month ago

/ocabot migration base_export_manager

pedrobaeza commented 1 month ago

You need to enroll reviewers

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

One way is that you review other PRs, and ask in exchange that they review yours.