OCA / social

Addons concerning odoo's social ERP features and messaging in general
https://odoo-community.org/project/99
GNU Affero General Public License v3.0
157 stars 600 forks source link

[15.0][ADD] mail_no_user_assign_notification: New module #1379

Closed victoralmau closed 3 months ago

victoralmau commented 3 months ago

New module

Please @pedrobaeza and @carolinafernandez-tecnativa can you review it?

@Tecnativa TT49257

carolinafernandez-tecnativa commented 3 months ago

The only user notification that is not working is when assigned new tasks as it is a many2many field and you can assign multiple users.

Configuration:

image

Mail received:

image

I have checked with purchase order and sales order and leads works perfectly!

victoralmau commented 3 months ago

Tasks are out of the scope of this module; moreover, it is not just adding the user_ids field because the project module uses another “different” mechanism.

HaraldPanten commented 3 months ago

Hi @victoralmau @pedrobaeza I think we did something quite similar (we did it for V16) Maybe you want to have a look and both try to get the best from each module? Maybe we could join efforts --> https://github.com/sygel-technology/sy-social/tree/16.0/mail_block_user_assigned_message

victoralmau commented 3 months ago

Hi @victoralmau @pedrobaeza I think we did something quite similar (we did it for V16) Maybe you want to have a look and both try to get the best from each module? Maybe we could join efforts --> https://github.com/sygel-technology/sy-social/tree/16.0/mail_block_user_assigned_message

I have reviewed what you indicate but I see that (although similar) they are different approaches (apply to the user_id field of the models defined in a system parameter, or indicate for each partner the model on which you want to do it), so I think they should be different modules.

pedrobaeza commented 3 months ago

Add ROADMAP.rst for commenting that this is not valid for project tasks users assignation, as the field is multi-relational. A specific extension would be needed.

victoralmau commented 3 months ago

Changes done.

OCA-git-bot commented 3 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 15.0-ocabot-merge-pr-1379-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 2618b8b5eb21a72ed3eafa54fc5d6bd67f22c913. Thanks a lot for contributing to OCA. ❤️