[16.0][FIX][REF] mail_show_follower: internal notes

[vvrossem]

This module aims to show the recipients of a message in the email header, but the previous implementation was not suitable for internal notes.

When logging an internal note with tagged users and/or partners, those specific recipients should be displayed as well as the document's followers subscribed to this message subtype.

When sending an email, the recipients should be the document's followers.

This is achieved by using the recipient of each notification line

[OCA-git-bot]

Hi @yajo, some modules you are maintaining are being modified, check this out!

[vvrossem]

Tests are failing because of mail_gateway_telegram.

[vvrossem]

@etobella I'm encountering issues with tests failing on mail_gateway_telegram. For example:

  File "/__w/social/social/mail_gateway_telegram/models/mail_gateway_telegram.py", line 71, in _get_channel_vals
    update.message.chat.description or False,
AttributeError: 'Chat' object has no attribute 'description'. Did you mean: 'set_description'?

Any idea what could be the issue ?

[etobella]

I think they made a change on the library. I will pin a version in order to avoid the issue. I will make it ASAP (tonight or tomorrow morning)

[vvrossem]

Thank you @yajo for your additional review :pray: . I'll handle it asap :)

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[fcvalgar]

Code review OK.

@fcvalgar please update your functional review. The part you highlight in the Mailhog interface does not belong to this module. Instead, this module adds recipients info in the message body, and I cannot see any of that in the screenshot. Maybe it was not installed when you tried it?

I think the behaviour is not as expected. The followers of the notes do not appear in the body of the message.

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1391-by-yajo-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 7f4afd94b6638793702e79bc6bf67aa890379c81. Thanks a lot for contributing to OCA. ❤️