OCA / social

Addons concerning odoo's social ERP features and messaging in general
https://odoo-community.org/project/99
GNU Affero General Public License v3.0
157 stars 600 forks source link

[16.0][FIX] mail_tracking: bounces and others #1406

Closed chienandalu closed 1 month ago

chienandalu commented 2 months ago

Some improvements/fixes detected in https://github.com/OCA/social/pull/1367 and brought to 16.0:

cc @Tecnativa

pedrobaeza commented 2 months ago

Can you check CI?

chienandalu commented 2 months ago

Looks like the branch is red due to mail_composer_cc_bcc TestMailCcBcc.test_upstream_file_hash test

That module has the mail.mail._send method patched and that test is a way to check if the hash for the upstream method has changed, which has happened last week...: https://github.com/OCA/OCB/commit/d492bbde35d2b52e975ca252588f5529f07027aa

It's a good way to check if your patch is missing something... but it blocks everything else when it does...

So it would be needed to fix the patched method and set the new hash

cc @hailangvn2023 @sonhd91 @sonhd91 @nilshamerlinck @hbrunn

nilshamerlinck commented 2 months ago

Hello @chienandalu thanks for the heads up! created https://github.com/OCA/social/pull/1407 and https://github.com/OCA/social/pull/1408 to do that

OCA-git-bot commented 1 month ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-1406-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at 72da77b052fc6a0094b794b25d5b5759869976f1. Thanks a lot for contributing to OCA. ❤️