search

OCA / spreadsheet

GNU Affero General Public License v3.0
46 stars 47 forks source link

[16.0][FIX] spreadsheet_oca: Show the "Add" button in invoice list #46

Closed CarlosRoca13 closed 1 month ago

CarlosRoca13 commented 1 month ago

If this files aren't charged just after the main file if some module that is charged before spreadsheet_oca makes a primary template, the button will not be shown.

Exmple: image

cc @Tecnativa TT50815

ping @pedrobaeza @chienandalu

pedrobaeza commented 1 month ago

Tested an working. The only comment is about the commit message. It's a FIX instead of an IMP, as there's something not working, and the first line should express what is fixing:

[FIX] spreadsheet_oca: Show the "Add" button in invoice list

If any module males a primary template from the ones where the button is added, the button wasn't be shown previously.

That's because the inheritance and load order works in OWL. The way to fix this is to make this load order deterministic specifying to be loaded after the corresponding template for being taken into account for primary views. This also required to split the templates file into several ones.
CarlosRoca13 commented 1 month ago

Change done @pedrobaeza

pedrobaeza commented 1 month ago

/ocabot merge minor

OCA-git-bot commented 1 month ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-46-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at ac4980b7eceaa694d5f833d9939ae0a3b787747a. Thanks a lot for contributing to OCA. ❤️