search

OCA / stock-logistics-availability

This repository contains modules to provide more information about product stock availability in terms of quantities (immediately usable, potential, unreserved ones, ...).
GNU Affero General Public License v3.0
7 stars 38 forks source link

[17.0] [MIG] stock_available: Migration to 17.0 #20

Closed bizzappdev closed 5 months ago

rousseldenis commented 5 months ago

/ocabot migration stock_available

bizzappdev commented 5 months ago

Code review.

Even if I suggest to move the 'mrp' configuration in the mrp available related module.

I'm not sure If I understand you correctly, but If we move the MRP configuration to the available MRP module, then that configuration will not be useful. This configuration itself is installing the module.

pedrobaeza commented 5 months ago

For me, that configuration should go out, as it's very poisoned: if the module is not migrated, it's not working and do users to put issues about it. And even if the module is migrated, I don't like the checks that install modules without total user awareness.

bizzappdev commented 5 months ago

For me, that configuration should go out, as it's very poisoned: if the module is not migrated, it's not working and do users to put issues about it. And even if the module is migrated, I don't like the checks that install modules without total user awareness.

I concur with your point @pedrobaeza . Let me remove it. Also there is a configuration for installing stock_available_immediately, That should also go away IMO.

bizzappdev commented 5 months ago

For me, that configuration should go out, as it's very poisoned: if the module is not migrated, it's not working and do users to put issues about it. And even if the module is migrated, I don't like the checks that install modules without total user awareness.

@pedrobaeza @rousseldenis Removed the configuration for module installation.

pedrobaeza commented 5 months ago

@rousseldenis do you see correct to remove that field? Or maybe I'm misunderstanding the meaning of it?

rousseldenis commented 5 months ago

Yes, that seems fair for me.

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt commented 5 months ago

/ocabot merge nobump

OCA-git-bot commented 5 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-20-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at 3294256a68bdd2ea7c168ab0bb6ea2dd9e3b9d76. Thanks a lot for contributing to OCA. ❤️

rpinset commented 3 months ago

Hello, could there not be a calculation problem? The immediately_usable_qty field gives the forecast quantity taking into account supplier receipts not yet received. image

This does not match the field name and description https://github.com/OCA/stock-logistics-availability/blob/ac926a5e3178369d8b252722622e8ab0c3bfae57/stock_available/models/product_product.py#L56