OCA / stock-logistics-availability

This repository contains modules to provide more information about product stock availability in terms of quantities (immediately usable, potential, unreserved ones, ...).
GNU Affero General Public License v3.0
7 stars 38 forks source link

Not assigned field #25

Open dante-envalia opened 4 months ago

dante-envalia commented 4 months ago

Module

The name of the module that has a bug.

Describe the bug

Calculated fields should always have a value assignes ValueError: Compute method failed to assign product.template(<NewId 0x76bc99cbe860>,).qty_available_not_res File: stock_available_unreserved/models/product_template.py

Original code:

    @api.depends("product_variant_ids.qty_available_not_res")
    def _compute_product_available_not_res(self):
        for tmpl in self:
            if isinstance(tmpl.id, models.NewId):
                continue
            tmpl.qty_available_not_res = sum(
                tmpl.mapped("product_variant_ids.qty_available_not_res")
            )

Proposed code:

    @api.depends("product_variant_ids.qty_available_not_res")
    def _compute_product_available_not_res(self):
        for tmpl in self:
            if isinstance(tmpl.id, models.NewId):
                tmpl.qty_available_not_res = False
                continue
            tmpl.qty_available_not_res = sum(
                tmpl.mapped("product_variant_ids.qty_available_not_res")
            )