OCA / stock-logistics-barcode

https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
158 stars 326 forks source link

[14.0][FIX] product_multi_barcode_supplierinfo: an empty barcode can only b.. #502

Closed eantones closed 1 year ago

eantones commented 1 year ago

…e assigned to one supplierinfo when barcode field is "" instead of False (NULL)

The sql constraint https://github.com/OCA/stock-logistics-barcode/blob/bc267289a696e3190e6fea9e39fb552e6f7e14ef/product_supplierinfo_barcode/models/supplierinfo.py#L13-L19 only allows duplicated barcodes if they are NULL (False), it doesn't if they are "".

@mariadforgeflow @LoisRForgeFlow can you please review. Thanks! :-)

mariadforgeflow commented 1 year ago

LGTM!

LoisRForgeFlow commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-502-by-LoisRForgeFlow-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-502-by-LoisRForgeFlow-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

LoisRForgeFlow commented 1 year ago

@eantones Today a new fix was included in the copier template repository, I think you should run the copier update once more to be able to merge (you can amend it to the copier update commit that you already have here).

eantones commented 1 year ago

@LoisRForgeFlow done! You can try to merge again. Thanks!! :-)

LoisRForgeFlow commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-502-by-LoisRForgeFlow-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-502-by-LoisRForgeFlow-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

LoisRForgeFlow commented 1 year ago

Yet another different error :(

Error: Docker login for 'ghcr.io' failed with exit code 1

I will retry later in case it was some network problem.

eantones commented 1 year ago

Ok, thanks @LoisRForgeFlow

LoisRForgeFlow commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-502-by-LoisRForgeFlow-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at e2543a06719392ff1e683ad7657b360f29ba1743. Thanks a lot for contributing to OCA. ❤️