search

OCA / stock-logistics-barcode

https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
158 stars 326 forks source link

[14.0] [REF] simplify logic, get rid of duplicate company field #526

Closed florentx closed 6 months ago

francesco-ooops commented 1 year ago

@legalsylvain what do you think of this change?

florentx commented 1 year ago

Just noticed that "company_id" is not saved on Product creation. Here the fix with related tests.

francesco-ooops commented 1 year ago

@florentx can you apply requested modifications?

or would you like for us to pick up your work and bring it to completion? let us know! :)

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

florentx commented 11 months ago

Changed to depend on product_variant_company

Test fails due to incompatibility with _check_duplicates in add-on product_multi_barcode, file product_multi_barcode/models/product_barcode.py

francesco-ooops commented 11 months ago

@florentx will you keep working on this or shall we pick it up?

florentx commented 11 months ago

@florentx will you keep working on this or shall we pick it up?

You can take over this PR and bring it to completion @francesco-ooops . Thanks

github-actions[bot] commented 6 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.