OCA / stock-logistics-barcode

https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
158 stars 324 forks source link

[14.0][IMP] product_barcode_constraint_per_company: simplify logic #537

Closed dessanhemrayev closed 6 months ago

dessanhemrayev commented 10 months ago

Change old method Update oca_dependencies file Fix tests

dessanhemrayev commented 10 months ago

Do not add new dependency to multi barcode module.

@legalsylvain Do you think we need to create a bridge module for that, or is there possibly another solution?

legalsylvain commented 10 months ago

multi barcode module is a module that is really changing a lot of things. The feature is not desired in some implementation. So in that case, indeed glue module looks a good solution, if you want to make the module product_barcode_constraint_per_company working with that module.

francesco-ooops commented 10 months ago

supersedes #526

geomer198 commented 9 months ago

@legalsylvain Could you please check changes?

francesco-ooops commented 9 months ago

@florentx good for you?

francesco-ooops commented 8 months ago

@OCA/logistics-maintainers good for merge?

francesco-ooops commented 8 months ago

@simahawk better now?

francesco-ooops commented 8 months ago

@simahawk good to go?

francesco-ooops commented 7 months ago

@simahawk good for you?

francesco-ooops commented 7 months ago

@simahawk waiting for your blessing :)

francesco-ooops commented 7 months ago

@simahawk help me Orsi-Wan Kenobi, you're my only hope

francesco-ooops commented 7 months ago

@pedrobaeza can this be merged based on existing reviews?

francesco-ooops commented 7 months ago

@pedrobaeza @simahawk kind reminder :)

dessanhemrayev commented 6 months ago

@pedrobaeza please check, I have corrected your comments) Thanks

OCA-git-bot commented 6 months ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-537-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 6 months ago

Congratulations, your PR was merged at 67df8ca8d9895040f5c6788077d7c86e3cbe198c. Thanks a lot for contributing to OCA. ❤️