OCA / stock-logistics-barcode

https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
158 stars 324 forks source link

[16.0][ADD] product_packaging_multi_barcode_stock_menu: view packaging on barcode list #541

Open santostelmo opened 10 months ago

santostelmo commented 10 months ago

Show packaging field in product barcode tree view

santostelmo commented 9 months ago

product_packaging_multi_barcode

@sebalix Should I make product_multi_barcode_stock_menu dependent of product_packaging_multi_barcode ?

sebalix commented 9 months ago

@santostelmo no we cannot do that neither sadly. I think the way it has been designed, we have to create a product_packaging_multi_barcode_stock_menu module to handle this need. I know its overkill but I do not see another solution.

In the long term, as both product and packaging are part of Odoo std (product module), I'm wondering why product_multi_barcode and product_packaging_multi_barcode couldn't be merge in one module (you install it and you get all your models coming from product extended with this multi barcodes feature), so we could have only one extra module that make the glue between product_multi_barcode with stock (without restricting this to a menu, so a better name would have been product_multi_barcode_stock for instance). But I don't know these modules nor why it has been designed this way, so for now we have to stick with what we have.

cc @simahawk

santostelmo commented 9 months ago

@santostelmo no we cannot do that neither sadly. I think the way it has been designed, we have to create a product_packaging_multi_barcode_stock_menu module to handle this need. I know its overkill but I do not see another solution.

In the long term, as both product and packaging are part of Odoo std (product module), I'm wondering why product_multi_barcode and product_packaging_multi_barcode couldn't be merge in one module (you install it and you get all your models coming from product extended with this multi barcodes feature), so we could have only one extra module that make the glue between product_multi_barcode with stock (without restricting this to a menu, so a better name would have been product_multi_barcode_stock for instance). But I don't know these modules nor why it has been designed this way, so for now we have to stick with what we have.

cc @simahawk

@sebalix I have created the module product_packaging_multi_barcode_stock_menu

QuocDuong1306 commented 7 months ago

Ping @santostelmo , Could you help to fix this?

santostelmo commented 7 months ago

@QuocDuong1306 I fixed the points mentioned above. @sebalix could you please check your change requests ?

cyrilmanuel commented 1 month ago

missing script on pre to change module name if its already installed

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk commented 1 month ago

@santostelmo this PR deserves a better description explaining the changes :wink: