search

OCA / stock-logistics-barcode

https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
158 stars 324 forks source link

[14.0][FIX] barcodes_generator_product_multi_barcode: fix inheritance #570

Closed aleuffre closed 7 months ago

aleuffre commented 7 months ago

This commit fixes an issue where the barcode generation was being overwritten not just for products, but for every model that inherited from the barcode.generate.mixin (users, locations, packages)

Additionally, it also fixes a SingletonError in case generate_barcode() was called with a multi recordset

OCA-git-bot commented 7 months ago

Hi @AshishHirapara, @dessanhemrayev, @CetmixGitDrone, some modules you are maintaining are being modified, check this out!

dessanhemrayev commented 7 months ago

/ocabot merge patch

OCA-git-bot commented 7 months ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-570-by-dessanhemrayev-bump-patch, awaiting test results.

OCA-git-bot commented 7 months ago

Congratulations, your PR was merged at 01fa81240bc03021265961217f0dcb7638be160a. Thanks a lot for contributing to OCA. ❤️

aleuffre commented 7 months ago

Please, change file name) barcode_generate_mixin.py to product.py

That was correct, but I didn't get the chance to do this fix :D