[14.0][REF] sale_input_barcode: refactor and split module

[aleuffre]

This PR splits sale_input_barcode in two modules:

• sale_input_barcode no longer depends on base_gs1_barcode and can scan any product
• sale_input_barcode_gs1 is a new auto-installing module (it installs when both sale_input_barcode and base_gs1_barcode are installed) that restores the functionality of sale_input_barcode exactly as it is now, before this PR.

There's some code refactoring to achieve this.

This PR is a follow-up from #581

To Do (possibly in other PRs):

• [ ] add as IMP to sale_input_barcode the functionality of updating the same Sale Order Line if the same barcode is scanned, see #581
• [ ] Give feedback to the user about what was scanned?

cc @dessanhemrayev @bealdav

[OCA-git-bot]

Hi @bealdav, some modules you are maintaining are being modified, check this out!

[aleuffre]

add as IMP to sale_input_barcode the functionality of updating the same Sale Order Line if the same barcode is scanned, see https://github.com/OCA/stock-logistics-barcode/pull/581

This functionality is actually quite hard to implement while maintaining the generality required by a mixin, as well as the module split... I need some more time to think about it. But it can be done in a later PR as well.

[bealdav]

Hi I have to dive in your code. In next days I hope. Thanks

[francesco-ooops]

@bealdav sorry to push but we're in a bit of a rush with this one, could you please take a look? Thanks!

[aleuffre]

Thank you for your review @bealdav , I've addressed all your points or commented under the ones where I'm unsure.

[francesco-ooops]

@bealdav shall we go? :)

[francesco-ooops]

@bealdav will you launch merge command?

[bealdav]

/ocabot merge major,

[OCA-git-bot]

Sorry @bealdav you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[bealdav]

I'm only maintainer on the first module, sorry

[francesco-ooops]

That's right!

@pedrobaeza could you help? Thanks!

[bealdav]

You could set me as maintainers of the second one ?

Thanks

[pedrobaeza]

/ocabot merge major

[OCA-git-bot]

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-596-by-pedrobaeza-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at b1c2fbf29cfb56d08ab52a9245046dd18b37a82f. Thanks a lot for contributing to OCA. ❤️