[16.0][MIG] stock_barcodes: Migration to 16.0

chienandalu commented 5 months ago

Followup to #587

Drop scan read logs feature, which use was deprecated already in the previous versions.
Pass bootstrap migration scripts.
Fix views issues.
Other code fixes.

cc @Tecnativa

@FranzPoize I've been doing the migration with @sergio-teruel, who's the main developer of the module in the spanish OCA days. We started from your migration head.

At this point the module is completely functional, although we're still tweaking the views to fit the previous state.

pedrobaeza commented 4 months ago

This doesn't contain #604

pedrobaeza commented 4 months ago

/ocabot migration stock_barcodes

chienandalu commented 4 months ago

This doesn't contain #604

Fixed

FranzPoize commented 4 months ago

Hello ! I pushed some stuff just after you created this PR I think. In it there was a lot of work to replace the always_reload feature of old odoo version.

chienandalu commented 4 months ago

Hi, @FranzPoize !

Do you mean this new stuff or something else?: https://github.com/OCA/stock-logistics-barcode/pull/587/commits/38288280b173ffc2487758a85edad3bb74959442#diff-f69121127ec9ebdc28296fa3a7f3760d71865de0267308101bf6d467fef4769cR106-R121

FranzPoize commented 4 months ago

No I mean this stuff https://github.com/OCA/stock-logistics-barcode/commit/38288280b173ffc2487758a85edad3bb74959442#diff-00871f58b13dd92c5ff7599bc210323e9a6e64bdbf58abd5a3c19c83428d5dbb

What you linked to is some other features we added:

Allowing scanning product on at a time in new picking (not use the total quant by default)
Forbidding picking validation if their is a move_line with the same location_id and location_dest_id
Offer an option to not check demand during picking (this solve the issue where if you reload after a picking creation you will not be able to pick more product without using the force action done)
Update all destination of all move_line when scanning a location (This allows destination to be scanned last because otherwise it does not work)

chienandalu commented 4 months ago

there was a lot of work to replace the always_reload feature of old odoo version. I mean this stuff https://github.com/OCA/stock-logistics-barcode/commit/38288280b173ffc2487758a85edad3bb74959442#diff-00871f58b13dd92c5ff7599bc210323e9a6e64bdbf58abd5a3c19c83428d5dbb

Can you elaborate on why this is needed? What's the issue you're trying to solve?

other features we added:

Allowing scanning product on at a time in new picking (not use the total quant by default)

Forbidding picking validation if their is a move_line with the same location_id and location_dest_id

Offer an option to not check demand during picking (this solve the issue where if you reload after a picking creation you will not be able to pick more product without using the force action done)

Update all destination of all move_line when scanning a location (This allows destination to be scanned last because otherwise it does not work)

I commented these with @sergio-teruel last week and some of them could be accomplished with the current config (I'm sure he can elaborate in detail :)). In any case, is better to limit the scope the PR to the module migration stuff and do any feature proposal in a later one

FranzPoize commented 4 months ago

You don't have to take those features if you don't want to. But you should take the always_reload feature imho because otherwise there is no update of many2one field unless there is a button pressed.

FranzPoize commented 4 months ago

In 14.0 there was this https://github.com/OCA/stock-logistics-barcode/blob/fe5c849fc9a6ec190eed2672086df22553c78d64/stock_barcodes/wizard/stock_barcodes_read_picking_views.xml#L160 This does not work anymore the code here https://github.com/OCA/stock-logistics-barcode/commit/38288280b173ffc2487758a85edad3bb74959442#diff-00871f58b13dd92c5ff7599bc210323e9a6e64bdbf58abd5a3c19c83428d5dbb replaces this always_reload feature.

And I said many2ones in my previous comment I made a mistake. This allows one2many fields and many2many field to update their data when an onchange event is triggered.

chienandalu commented 4 months ago

Hi @FranzPoize let me check it and I tell you

lk-eska commented 4 months ago

Is there any progress on this PR?

sergio-teruel commented 4 months ago

Hi @ik-eska two commits 4 days ago... Any progress?? Yes...

lk-eska commented 4 months ago

Sorry @sergio-teruel I haven't noticed them.

sergio-teruel commented 4 months ago

jaja... don't worry... :smile:

sergio-teruel commented 4 months ago

Cherry pick from 15.0 ef65da1c6e432e37dd045a77314e79c74a60fe9b

pedrobaeza commented 1 month ago

@chienandalu @sergio-teruel please fix the CI and finish this for merging it.

josepmy commented 2 weeks ago

Se puede ayudar en algo para avanzar el merge?

OCA / stock-logistics-barcode

[16.0][MIG] stock_barcodes: Migration to 16.0 #610