OCA / stock-logistics-barcode

https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
160 stars 330 forks source link

[IMP] barcodes_generator_abstract: set 'python-barcode' as external_dependencies #616

Closed isaako34 closed 4 months ago

isaako34 commented 4 months ago

Since using the PyPI package has been the recommended way since v12.0 (see https://github.com/odoo/odoo/pull/25549), this commit sets 'python-barcode' as an external dependency and removes the 'odoo_addon' key from setup.py

OCA-git-bot commented 4 months ago

Hi @legalsylvain, some modules you are maintaining are being modified, check this out!

isaako34 commented 4 months ago

Hello @luisg123v could you please review? This is in follow-up to https://github.com/OCA/stock-logistics-barcode/pull/615#discussion_r1616315262

isaako34 commented 4 months ago

@luisg123v ready for review

OCA-git-bot commented 4 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-616-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot commented 4 months ago

Congratulations, your PR was merged at 65f02d1af23c33720cafb1d8f8f92fa4e6cad9e9. Thanks a lot for contributing to OCA. ❤️

luisg123v commented 4 months ago

If CI is happy, I'm happy

And so we are :laughing: