[13.0][FIX] stock_picking_report_valued: valued line computation

OCA / stock-logistics-reporting

Provides Odoo Logistics reporting modules

https://odoo-community.org/psc-teams/logistics-18

GNU Affero General Public License v3.0

66 stars 232 forks source link

[13.0][FIX] stock_picking_report_valued: valued line computation #221

Closed chienandalu closed 2 years ago

chienandalu commented 2 years ago

The fix in fac3997ee518f2c984776d8a06860fb5e80ccee2 didn't consider move lines without a linked sale line. That would end up in inconsistent calculations and even the original line rewriting.

cc @Tecnativa TT38863

ping @pedrobaeza @carlosdauden

cc @ao-landoo

pedrobaeza commented 2 years ago

I see that this is not enough: we need to do other if level. The first one is if valued_line, and the second one if the quantity is different, and in the first level, do the UoM check.

chienandalu commented 2 years ago

Changes done:

Values of the recordset initialized at first
We exit the loop if no linked sale line.
Create the virtual line with the copy if we have to recompute the prices either for qty or uom
Update price_unit accordingly depending on the case

pedrobaeza commented 2 years ago

@ao-landoo please check that your PR was causing this side effect.

pedrobaeza commented 2 years ago

Let's fast-track it for voiding further problems:

/ocabot merge patch

OCA-git-bot commented 2 years ago

On my way to merge this fine PR! Prepared branch 13.0-ocabot-merge-pr-221-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at 1035d302b8dcc8247180238a84270b4e511e6fd1. Thanks a lot for contributing to OCA. ❤️

pedrobaeza commented 2 years ago

This should be fw-port it to v14 and v15. @ao-landoo do you handle it?