OCA / stock-logistics-reporting

Provides Odoo Logistics reporting modules
https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
66 stars 232 forks source link

[15.0][ADD] stock_picking_report_external_note #269

Closed Shide closed 1 year ago

Shide commented 1 year ago

New module to displan a note on the Deliver Slip report.

This module doesn't have any "rare" dependency. Just a new field (html, not text) and inherit on the Delivery Slip report.

resolves #264

MT-2153 @moduon @yajo @rafaelbn @anddago78 please review if you want :)

rousseldenis commented 1 year ago

@Shide Thanks for this. I think there is already such module. I'll try to find out where it is.

Shide commented 1 year ago

I find https://github.com/OCA/stock-logistics-workflow/tree/14.0/stock_delivery_note but this module is intended to be used as a delivery note for the transport company, not for the customer (because the delivery dependency).

rousseldenis commented 1 year ago

I find https://github.com/OCA/stock-logistics-workflow/tree/14.0/stock_delivery_note but this module is intended to be used as a delivery note for the transport company, not for the customer (because the delivery dependency).

Yes I saw the comment. But I'm quite sure there is something

rousseldenis commented 1 year ago

There is:

But maybe too much code. This one is more simple

rafaelbn commented 1 year ago

Hello @rousseldenis !

As you can check here https://github.com/OCA/stock-logistics-reporting/issues/264 I analysed all before making the PR, I Opened issue time ago 😄

I know already all the alternatives and no one is the requirement.

https://github.com/OCA/stock-logistics-reporting/tree/14.0/stock_picking_comment_template when you have templates or comments. In this use case every comment is different in each picking https://github.com/OCA/stock-logistics-reporting/tree/14.0/stock_picking_report_custom_description bring the description of sales to picking

About you comment

But maybe too much code. This one is more simple

Not only much more simple,

Thank you very much for you review! ❤️

rousseldenis commented 1 year ago

Hello @rousseldenis !

As you can check here #264 I analysed all before making the PR, I Opened issue time ago smile

I know already all the alternatives and no one is the requirement. https://github.com/OCA/stock-logistics-reporting/tree/14.0/stock_picking_comment_template when you have templates or comments. In this use case every comment is different in each picking https://github.com/OCA/stock-logistics-reporting/tree/14.0/stock_picking_report_custom_description bring the description of sales to picking

About you comment

But maybe too much code. This one is more simple

Not only much more simple,

  • Is different functionality
  • You could need both at the same time

Thank you very much for you review! heart

Yes, I saw it. I just wondering myself why nobody proposed that already as it seems such a common needs :sweat_smile:

So, let's move forward

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Shide commented 1 year ago

@rafaelbn done refactor of view

rousseldenis commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 15.0-ocabot-merge-pr-269-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at d9406a117de0b01f5a54517150814776e4dfcc01. Thanks a lot for contributing to OCA. ❤️