Closed slitheryduke11 closed 1 year ago
Hi @luisg123v, @JordiBForgeFlow, @ernestotejeda . I think the migration of this module to 16.0 is ready.
I would appreciate it if you could help me with the review.
Thanks in advance!
/ocabot migration stock_quantity_history_location
/ocabot merge nobump
Sorry @luisg123v you are not allowed to merge.
To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.
If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers
key of its manifest.
@rousseldenis,
It seems I can't merge here. Could you help me running the merge command, please?
Regards,
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge nobump
On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-275-by-rousseldenis-bump-nobump, awaiting test results.
@rousseldenis,
It seems I can't merge here. Could you help me running the merge command, please?
Regards,
Indeed, as you have to be already a maintainer of the module to have merge rights.
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-275-by-rousseldenis-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
Hi, @rousseldenis. I've updated the maintainers list to give it a line-by-line format.
Hi, @rousseldenis. I've updated the maintainers list to give it a line-by-line format.
😅 maybe unnecessary if pre-commit does not warn
@rousseldenis could you re-run the merge command, please?
/ocabot merge nobump
This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-275-by-moylop260-bump-nobump, awaiting test results.
Congratulations, your PR was merged at c13047c88ed4802336ca0706220e5daccfecd0cd. Thanks a lot for contributing to OCA. ❤️
The group attribute is added to the 'include_child_locations' field because the module could not be installed otherwise.
Also, a conditional that is never reached is removed because the model's native method always returns a dictionary, making the conditional unnecessary.