OCA / stock-logistics-reporting

Provides Odoo Logistics reporting modules
https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
66 stars 232 forks source link

[16.0][MIG] stock_quantity_history_location: Migration to 16.0 #275

Closed slitheryduke11 closed 1 year ago

slitheryduke11 commented 1 year ago

The group attribute is added to the 'include_child_locations' field because the module could not be installed otherwise.

Also, a conditional that is never reached is removed because the model's native method always returns a dictionary, making the conditional unnecessary.

slitheryduke11 commented 1 year ago

Hi @luisg123v, @JordiBForgeFlow, @ernestotejeda . I think the migration of this module to 16.0 is ready.

I would appreciate it if you could help me with the review.

Thanks in advance!

rousseldenis commented 1 year ago

/ocabot migration stock_quantity_history_location

luisg123v commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

Sorry @luisg123v you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

luisg123v commented 1 year ago

@rousseldenis,

It seems I can't merge here. Could you help me running the merge command, please?

Regards,

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-275-by-rousseldenis-bump-nobump, awaiting test results.

rousseldenis commented 1 year ago

@rousseldenis,

It seems I can't merge here. Could you help me running the merge command, please?

Regards,

Indeed, as you have to be already a maintainer of the module to have merge rights.

OCA-git-bot commented 1 year ago

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-275-by-rousseldenis-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

slitheryduke11 commented 1 year ago

Hi, @rousseldenis. I've updated the maintainers list to give it a line-by-line format.

rousseldenis commented 1 year ago

Hi, @rousseldenis. I've updated the maintainers list to give it a line-by-line format.

😅 maybe unnecessary if pre-commit does not warn

luisg123v commented 1 year ago

@rousseldenis could you re-run the merge command, please?

moylop260 commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-275-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at c13047c88ed4802336ca0706220e5daccfecd0cd. Thanks a lot for contributing to OCA. ❤️