OCA / stock-logistics-reporting

Provides Odoo Logistics reporting modules
https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
66 stars 232 forks source link

[FIX] stock_quantity_history_location: Migrate js to OWL #282

Closed rolandojduartem closed 1 year ago

rolandojduartem commented 1 year ago

This commit solves the error "Non loaded module stock_quantity_history_location.InventoryReportListController" because the dependency stock.InventoryReportListController was missed. The dependency from stock was migrated to OWL [1], so it is inherited using the OWL to preserve the behavior.

References:

rolandojduartem commented 1 year ago

This is in development phase

OCA-git-bot commented 1 year ago

Hi @luisg123v, some modules you are maintaining are being modified, check this out!

rolandojduartem commented 1 year ago

Hi, @luisg123v, @imanie383 and @desdelinux, please, could you review this PR? Do you know anything about the lint in the pre-commit?

luisg123v commented 1 year ago

Hi @sebasdrk17,

Could you review, please?

rolandojduartem commented 1 year ago

Hi, @luisg123v and @imanie383, I applied your suggestions.

sebasdrk17 commented 1 year ago

@luisg123v Am I still needed here? I've seen that @imanie383 has already review

luisg123v commented 1 year ago

@luisg123v Am I still needed here? I've seen that @imanie383 has already review

@sebasdrk17 maybe not as needed anymore, but any comment is welcomed anyway.

rolandojduartem commented 1 year ago

Hi, @luisg123v and @imanie383, I applied your suggestions.

rolandojduartem commented 1 year ago

Hi, @luisg123v and @imanie383, could you review this PR again? CI is green now

rolandojduartem commented 1 year ago

Hi, @luisg123v and @imanie383, what do you think now? I could not make the groups attribute works for this inheritance, it would be great to remove the js file

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-282-by-luisg123v-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 928abb2ce3a11eb7cbb7324ce614b315e9988c36. Thanks a lot for contributing to OCA. ❤️