search

OCA / stock-logistics-transport

Transport management in Odoo
GNU Affero General Public License v3.0
61 stars 126 forks source link

[17.0] [ADD] tms_account_asset #138

Closed santiagordz closed 1 month ago

santiagordz commented 3 months ago

https://github.com/OCA/stock-logistics-transport/issues/127#issuecomment-2265775194

@marcelsavegnago I was already working in this implementation, what do you think about it? It is still not finished but i'm opening the PR so you can see it and suggest enhancements. I will take a look at https://github.com/OCA/account-financial-tools/pull/1802 and migrate as much as possible.

Dependencies

marcelsavegnago commented 3 months ago

For me, the issue with this type of implementation is that it is not generic and forces the use of TMS. Integrating the asset with the fleet should be independent of TMS. I believe that considering the generic use of things makes more sense than implementing everything in TMS.

marcelsavegnago commented 3 months ago

Take a look at the PR I sent you. If you could review it in version 14.0, it would be better to merge it there and then port it to version 17.0. However, since the community tends to focus more on newer versions, we can migrate it to version 17 and propose it there.

max3903 commented 1 month ago

@EdgarRetes Can you rebase?

max3903 commented 1 month ago

/ocabot merge nobump

OCA-git-bot commented 1 month ago

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-138-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at c59227ab785c509fe1c905f5568d864e1d0e9d9d. Thanks a lot for contributing to OCA. ❤️