16.0 [FIX] shipment_advice: set is_fully_loaded_in_shipment False when no move_line_ids

OCA / stock-logistics-transport

Transport management in Odoo

GNU Affero General Public License v3.0

61 stars 126 forks source link

Closed IT-Ideas closed 2 months ago

IT-Ideas commented 3 months ago

As all() is True when the iterable is empty is_fully_loaded_in_shipment becomes True, which does not have sense since nothing was to be loaded.

xavier-bouquiaux commented 2 months ago

LGTM

jbaudoux commented 2 months ago

cc @sebalix @rousseldenis @sbejaoui

jbaudoux commented 2 months ago

/ocabot merge patch

OCA-git-bot commented 2 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-140-by-jbaudoux-bump-patch, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 22d9f42b21f899e9dbc001701bb128c1f734910a. Thanks a lot for contributing to OCA. ❤️