[15.0][IMP] stock_inventory: adjust restriction

[AaronHForgeFlow]

This change allows to create several inventory adjustments on the same location if the products involved are different

You may say that creating inventory adjustment in the same location by product category is not efficient and I agree with that. However, the possibility is there, and the constraint should not be raised in this case.

@ ForgeFlow

[AaronHForgeFlow]

CI fixed now :tada:

[AaronHForgeFlow]

@rousseldenis , @JordiMForgeFlow I dediced to fix the tests in the stock_cycle_count module, indeed the test that was failing was actually not testing anything as long the inventory adjustment was never created in that test.

for now I left the method _get_overlapping_inventories as self.ensure_one(), for the purpose of the PR that is sufficient. If this change is a blocking change then I can consider make it multi.

[JordiMForgeFlow]

@AaronHForgeFlow could you add some test to validate the new changes for the constrain?

[AaronHForgeFlow]

@JordiMForgeFlow Added the test. Also remove the constraint check in the action_in_progress method. It is not necessary as the constraint method depends in the state. Adapted a bit the code.

[MiquelRForgeFlow]

conflicts

[AaronHForgeFlow]

conflicts

rebased & solved

[JoanSForgeFlow]

Hi @AaronHForgeFlow

I've noticed we have overlapping PRs (https://github.com/OCA/stock-logistics-warehouse/pull/2021) . Here are my observations and proposal:

1. Review of this PR:

   • This PR improves the system by allowing two stock inventories in the same location for different products.
   • However, when performing a general review of a product in a global location (like a warehouse), all interior sublocations are blocked.
   • In my opinion, only sublocations where the product being reviewed is located should be blocked.
   • Sublocations without any quant under review should remain accessible.

2. My Proposal:

   • In my PR I have done a small refactor of the to_do, where to_do represents the quant currently in a stock inventory in progress.
   • With my change, only the stock.inventory reviewing a quant already marked as to_do = True gets blocked in order to allow reviews in sublocations where this product is not in stock. (You can review test_09 of my PR, this is the one I think this PR is not covering https://github.com/OCA/stock-logistics-warehouse/pull/2021/files#diff-4307516705b49705a1076c0c27cb158684c4bde931c08199f7273efa32d1de7cR457 )

I hope this clarifies my proposal. Looking forward to your thoughts.

Thanks.

[AaronHForgeFlow]

I am closing this PR in favor of https://github.com/OCA/stock-logistics-warehouse/pull/2021/ Please do not delete the branch

The other PR covers more use cases than this one, and that is why it is ok to me to keep the other.