OCA / stock-logistics-workflow

Odoo Stock, Workflow and Organization
GNU Affero General Public License v3.0
226 stars 642 forks source link

[16.0][FIX] stock_picking_invoice_link: Avoid inconsistent computes #1625

Closed rousseldenis closed 2 months ago

rousseldenis commented 2 months ago

Related to https://github.com/OCA/stock-logistics-workflow/pull/1620

@pedrobaeza @chienandalu In fact, you changed the 'store' attribute of 'picking_count' field. But this is incoherent as two fields should not be computed with the same method if one is store and not the other one.

This fixes that problem highlighted by the warning in Odoo log.

This is the log now:

image

https://github.com/OCA/stock-logistics-workflow/actions/runs/9513693545/job/26224323631?pr=1625#step:8:675

chienandalu commented 2 months ago

Thanks @rousseldenis I'll fix that

rousseldenis commented 2 months ago

Thanks @rousseldenis I'll fix that

We can merge this

OCA-git-bot commented 2 months ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-1625-by-pedrobaeza-bump-patch, awaiting test results.

rousseldenis commented 2 months ago

Thanks for the investigation, @rousseldenis

@chienandalu this is happening the same in v17 and v15.

/ocabot merge patch

Welcome.

I don't desperate to have this : https://github.com/orgs/community/discussions/11592

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at d2c9a718a730acbc6838c67d9ac232e350483876. Thanks a lot for contributing to OCA. ❤️

chienandalu commented 2 months ago

@chienandalu this is happening the same in v17 and v15.

I'll take care of it