search

OCA / stock-logistics-workflow

Odoo Stock, Workflow and Organization
GNU Affero General Public License v3.0
229 stars 650 forks source link

[TESTS] Check warnings #1632

Closed rousseldenis closed 19 hours ago

rousseldenis commented 4 months ago

@sbidoul @pedrobaeza @OCA/core-maintainers This is a proof of concept that shows how to trigger a failing check on PR's main page in order to warn people about current errors (showed also in tests) and warnings (the main goal of this).

I found that a lot of repositories have bunches of warnings that are never addressed, but should.

The idea is to warn earlier (before merge) people about those warnings. As github has no intermediate (just fail/success) status for checks we cannot do that in normal checks and has to be on separate one.

The idea is to collect logs across matrix steps and run checkog-odoo. The difficult part was to generate unique log file id (if someone has better idea).

Comments are welcome !

hbrunn commented 4 months ago

yes please!

pedrobaeza commented 4 months ago

Well, it sounds good to have it. Any drawback with the storage? Do we have a limit?

sbidoul commented 4 months ago

@rousseldenis that's nice. Related: https://github.com/OCA/oca-addons-repo-template/issues/120

We could also enable this with an environment variable in oca-ci: https://github.com/OCA/oca-ci/issues/10

github-actions[bot] commented 1 day ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.