search

OCA / stock-logistics-workflow

Odoo Stock, Workflow and Organization
GNU Affero General Public License v3.0
226 stars 642 forks source link

[16.0][FIX] stock_picking_invoice_link: Avoid doble compute picking_count #1636

Closed Segui-S73 closed 2 months ago

Segui-S73 commented 2 months ago

After the change added in the commit [FIX] stock_picking_invoice_link: Avoid inconsistent computes the picking_count field is being calculated twice. This generates a strange interaction with the "payment.return" when confirming in which it checks if the generated account.move is balanced ahead of time and prevents it from being created.

rousseldenis commented 2 months ago

Thanks @Segui-S73!

rousseldenis commented 2 months ago

/ocabot merge patch

OCA-git-bot commented 2 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1636-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot commented 2 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-1636-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 6556f40fb02fddb1a33a51519d46a8a2c6cab746. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot commented 2 months ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1636-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 2 months ago

Sorry for the double merging command. I cancelled mine.