Closed jcadhoc closed 1 month ago
@jcadhoc Could you fix tests ? Thanks
@jcadhoc
2024-07-10 14:53:10,538 248 ERROR odoo odoo.addons.stock_restrict_lot.tests.test_restrict_lot: ERROR: TestRestrictLot.test_procurement_with_2_steps_output
Traceback (most recent call last):
File "/__w/stock-logistics-workflow/stock-logistics-workflow/stock_restrict_lot/tests/test_restrict_lot.py", line 215, in test_procurement_with_2_steps_output
assert_move_line_per_lot_and_location(
File "/__w/stock-logistics-workflow/stock-logistics-workflow/stock_restrict_lot/tests/test_restrict_lot.py", line 194, in assert_move_line_per_lot_and_location
self.assertEqual(concern_move_line.reserved_uom_qty, expect_reserved_qty)
AttributeError: 'stock.move.line' object has no attribute 'reserved_uom_qty'
BTW there already was https://github.com/OCA/stock-logistics-workflow/pull/1550 but its CI does not look any better.
And I would be curious to know what you think about https://github.com/OCA/stock-logistics-workflow/pull/1560.
Any update @jcadhoc?
@rousseldenis Thanks for reminder, i will see it
@StefanRijnhart Sorry, i didnt see the older pr, for me its the same if i give +1 or we merge this, technically seems the same but my pr have precommit ok.
@jcadhoc No, go ahead, the other PR is not responding. Can you check my other comments?
@rousseldenis @StefanRijnhart All green this time!
Sorry for the delay, i think it's ok to merge, let mi know if i miss something else..
Thank you!
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
Thanks, looking good now. Please squash the last commit [IMP] : pre-commit auto fixes
into the migration commit as it corrects the linting of a change in that commit.
@StefanRijnhart Ready!
Thanks for guide me :)
It's ready for merge @StefanRijnhart?
@peluko00 Yes!
/ocabot merge nobump
This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1652-by-StefanRijnhart-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 5971a5f8f52fb13cf2e86f6627a8d4dc1b28da24. Thanks a lot for contributing to OCA. ❤️
/ocabot migration stock_restrict_lot