OCA / stock-logistics-workflow

Odoo Stock, Workflow and Organization
GNU Affero General Public License v3.0
226 stars 642 forks source link

[15.0][ADD] stock_picking_operation_manual_lot_selection #1661

Closed StephaneMangin closed 1 month ago

StephaneMangin commented 1 month ago

This module allows you to force the manual selection of a Serial Number/lot in the picking operations. This is useful when you want to ensure that the right Serial Number/lot is selected for this given operation.

yostashiro commented 1 month ago

The objective of the module seems to overlap with https://github.com/OCA/stock-logistics-warehouse/tree/15.0/stock_quant_manual_assign. Is there something the existing module doesn't cover?

StephaneMangin commented 1 month ago

Module renamed to stock_picking_operation_manual_lot_selection

StephaneMangin commented 1 month ago

The objective of the module seems to overlap with https://github.com/OCA/stock-logistics-warehouse/tree/15.0/stock_quant_manual_assign. Is there something the existing module doesn't cover?

This doesn't seem to be the same workflow. In this module, we want the user to manually select a lot in the operation view by keeping the same ergonomic workflow and block the picking validation if no selection occurs and should have been.

rousseldenis commented 1 month ago

@StephaneMangin What is missing in Odoo stock module about this ? In fact, you can use the 'Use Existing Ones' option in stock.picking.type configuration. And then, Odoo won't validate the operation until you choose a lot.

Or am I missing something ?

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

StephaneMangin commented 1 month ago

@StephaneMangin What is missing in Odoo stock module about this ? In fact, you can use the 'Use Existing Ones' option in stock.picking.type configuration. And then, Odoo won't validate the operation until you choose a lot.

Or am I missing something ?

Hi @rousseldenis Thanks for your feedback. In fact, when using the option Use Existing Ones, Odoo almost blindly take a lot, in case we want the user to select the 'proper' lot number for the 'proper' product he has, we can't use this option efficiently without heavily change the standard behavior. That's why we choose to add a new field replacing the original one with the operation type condition to force the user to select the 'proper' lot manually.

simahawk commented 1 month ago

/ocabot merge nobump

OCA-git-bot commented 1 month ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-1661-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at d49a6218d2d6c955c53db7bfd7a5ae81c80b8011. Thanks a lot for contributing to OCA. ❤️