search

OCA / storage

GNU Affero General Public License v3.0
70 stars 159 forks source link

fs_storage: add possibility to define options values from env. #303

Closed adrienpeiffer closed 9 months ago

sbidoul commented 10 months ago

Looks good (code review). This should simplify configuration by letting us configure everything in a record with embedded environment variables such as, say, AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY.

OCA-git-bot commented 10 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

adrienpeiffer commented 9 months ago

@lmignon Could be merged for Xmas ?

sbidoul commented 9 months ago

/ocabot merge minor

OCA-git-bot commented 9 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-303-by-sbidoul-bump-minor, awaiting test results.

sbidoul commented 9 months ago

@adrienpeiffer can you handle the two comments from Simone?

sbidoul commented 9 months ago

I have cancelled the merge.

OCA-git-bot commented 9 months ago

Congratulations, your PR was merged at 359ac46a4a460c1ebee6890b343109df5f9620e0. Thanks a lot for contributing to OCA. ❤️

adrienpeiffer commented 9 months ago

@sbidoul Seems not cancelled. I'll handle that in an other PR.