OCA / storage

GNU Affero General Public License v3.0
66 stars 148 forks source link

[16.0][CHG] fs_base_multi_image: drag and drop fixes #332

Closed benwillig closed 1 month ago

benwillig commented 5 months ago
OCA-git-bot commented 5 months ago

Hi @lmignon, some modules you are maintaining are being modified, check this out!

lmignon commented 4 months ago

@benwillig Why do we need to create the relation on drag and drop? Can we add a relation and save it when the parent is saved?

benwillig commented 4 months ago

@lmignon That's what I wanted to do, unfortunately I didn't find the right way to do it with the new framework.

benwillig commented 1 month ago

@lmignon I finally found the way to make it work as it was in the old widget. And it also works when saving a specific image directly on the relation record.

lmignon commented 1 month ago

@bealdav Can you take a look at this?

bealdav commented 1 month ago

Yes I 'll dive in.

bealdav commented 1 month ago

Thanks for this improvement even if don't understand the full details.

Nice to see Kanban view completed with some fields.

As product.product view doesn't allow to edit images, don't you think that this view could show kanban view instead of tree ? It's a better visual view for users.

benwillig commented 1 month ago

Yes we can display the kanban view by default. What do you think @lmignon ?

lmignon commented 1 month ago

Yes we can display the kanban view by default. What do you think @lmignon ?

Yes we can on the product.product view.

bealdav commented 1 month ago

It works nicely in prod db, really thanks

bealdav commented 1 month ago

Also this PR https://github.com/OCA/storage/pull/370 seems ok. What do you think ?

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

lmignon commented 1 month ago

/ocabot merge patch

OCA-git-bot commented 1 month ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-332-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at 1776ecb65de855ebabb6f18428371d7d3342c0b5. Thanks a lot for contributing to OCA. ❤️